KoviAnusha commented on code in PR #57465:
URL: https://github.com/apache/airflow/pull/57465#discussion_r2476323113
##########
airflow-core/src/airflow/api_fastapi/execution_api/routes/asset_events.py:
##########
@@ -86,9 +86,9 @@ def get_asset_event_by_asset_name_uri(
if name and uri:
where_clause = and_(AssetModel.name == name, AssetModel.uri == uri)
elif uri:
- where_clause = and_(AssetModel.uri == uri, AssetModel.active.has())
+ where_clause = and_(AssetModel.uri == uri, AssetModel.active.has()) #
type: ignore[attr-defined]
Review Comment:
Yes, you are right. This is unnecessary. Thanks for pointing that out.
Removing it.
##########
airflow-core/src/airflow/api_fastapi/execution_api/routes/task_instances.py:
##########
@@ -447,7 +446,7 @@ def _create_ti_state_update_query_and_update_state(
session: SessionDep,
dag_bag: DagBagDep,
dag_id: str,
-) -> tuple[Update, TaskInstanceState]:
+) -> tuple[Update, str]:
Review Comment:
Thank you. I will work on this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
