HyunWooZZ commented on code in PR #60689:
URL: https://github.com/apache/airflow/pull/60689#discussion_r2700998206
##########
providers/snowflake/src/airflow/providers/snowflake/hooks/snowflake_sql_api.py:
##########
@@ -78,6 +79,7 @@ class SnowflakeSqlApiHook(SnowflakeHook):
:param token_renewal_delta: Renewal time of the JWT Token in timedelta
:param deferrable: Run operator in the deferrable mode.
:param api_retry_args: An optional dictionary with arguments passed to
``tenacity.Retrying`` & ``tenacity.AsyncRetrying`` classes.
+ :param http_timeout_seconds: Optional timeout for http requests.
Review Comment:
Sorry, I misunderstood your comment.
Currently, the invocation flow for a query in the hook is:
execute_query -> _make_api_call_with_retries -> request
So we need to change execute_query signature also async method also.
e.g pseudo code like this.
```python
def execute_query(some_args, http_args=default_args):
_make_api_call_with_retries(some_args, http_args)
def _make_api_call_with_retries(origin_param, http_args):
request(http_args)
```
In short, I understand this as a suggestion to shift the responsibility to
the calling side.
Is that right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
