HyunWooZZ commented on code in PR #60689:
URL: https://github.com/apache/airflow/pull/60689#discussion_r2701014921
##########
providers/snowflake/src/airflow/providers/snowflake/hooks/snowflake_sql_api.py:
##########
@@ -78,6 +79,7 @@ class SnowflakeSqlApiHook(SnowflakeHook):
:param token_renewal_delta: Renewal time of the JWT Token in timedelta
:param deferrable: Run operator in the deferrable mode.
:param api_retry_args: An optional dictionary with arguments passed to
``tenacity.Retrying`` & ``tenacity.AsyncRetrying`` classes.
+ :param http_timeout_seconds: Optional timeout for http requests.
Review Comment:
> think we should avoid it.
This is just 1 parameter out of so many that can be passed to request.
I rather have request_kwargs then each user can pass any parameter accepted
by requests.
First i understood change :param http_timeout_seconds: -> :param
request_kwargs:.
I just wanted to satisfy both sync and async http request.
But if we pass kwargs, I thought we need to pass kwargs for both or kwargs
like
`dict {sync: dict(some), async_session: dict{some}, async_request:
dict{some}}`
So i thought that is not intuitive way.
>I think that is how we do it in other http related operators?
I reference dbt hook :)
https://airflow.apache.org/docs/apache-airflow-providers-dbt-cloud/stable/_modules/airflow/providers/dbt/cloud/hooks/dbt.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
