amoghrajesh opened a new pull request, #60776: URL: https://github.com/apache/airflow/pull/60776
<!-- Thank you for contributing! Please provide above a brief description of the changes made in this pull request. Write a good git commit message following this guide: http://chris.beams.io/posts/git-commit/ Please make sure that your code changes are covered with tests. And in case of new features or big changes remember to adjust the documentation. Feel free to ping (in general) for the review if you do not see reaction for a few days (72 Hours is the minimum reaction time you can expect from volunteers) - we sometimes miss notifications. In case of an existing issue, reference it using one of the following: * closes: #ISSUE * related: #ISSUE --> --- ##### Was generative AI tooling used to co-author this PR? <!-- If generative AI tooling has been used in the process of authoring this PR, please change below checkbox to `[X]` followed by the name of the tool, uncomment the "Generated-by". --> - [x] No <!-- Generated-by: [Tool Name] following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions) --> --- Defining `TaskInstanceKey` in task-sdk as exposing it as a part of the SDK public API. This enables providers to use `TaskInstanceKey` without depending on airflow-core models (older path). For context, `TaskInstanceKey` provides task information `(dag_id, task_id, run_id, map_index, try_number)` which is used now for: - Public REST API - Operator link interfaces used by 100+ providers Why not follow this comment: https://github.com/apache/airflow/blob/main/airflow-core/src/airflow/executors/workloads.py#L77 and actually do it? There are a few blockers to that. - While TaskInstance model now has a UUID primary key, `TaskInstanceKey` still remains as the interface for public APIs and provider contracts due to backcompat (airflow 2.x doesn't have `uuid`) - We should be able to do this only when min version of airflow for providers reaches 3.x - XCOM API could be a potential blocker here too because dag_id, run_id, task_id is extensively used there * Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged. * For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed. * When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). * For significant user-facing changes create newsfragment: `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
