amoghrajesh commented on code in PR #60776: URL: https://github.com/apache/airflow/pull/60776#discussion_r2707003429
##########
task-sdk/src/airflow/sdk/bases/operatorlink.py:
##########
@@ -23,8 +23,8 @@
import attrs
if TYPE_CHECKING:
- from airflow.models.taskinstancekey import TaskInstanceKey
from airflow.sdk import BaseOperator
+ from airflow.sdk.types import TaskInstanceKey
Review Comment:
Good comment, I went through the list and mostly executors use it for non
typing along with these exceptions:
1.
https://github.com/apache/airflow/blob/728079af9b0e0fe60b44b27e34debfce10e249c6/providers/edge3/src/airflow/providers/edge3/worker_api/routes/logs.py#L18
2.
https://github.com/apache/airflow/blob/728079af9b0e0fe60b44b27e34debfce10e249c6/providers/edge3/src/airflow/providers/edge3/models/edge_job.py#L30
3. ES task handler:
https://github.com/apache/airflow/blob/728079af9b0e0fe60b44b27e34debfce10e249c6/providers/elasticsearch/src/airflow/providers/elasticsearch/log/es_task_handler.py#L92-L113
4. OS task handler:
https://github.com/apache/airflow/blob/728079af9b0e0fe60b44b27e34debfce10e249c6/providers/opensearch/src/airflow/providers/opensearch/log/os_task_handler.py#L79-L100
5. Edge provider datamodels:
https://github.com/apache/airflow/blob/728079af9b0e0fe60b44b27e34debfce10e249c6/providers/edge3/src/airflow/providers/edge3/worker_api/datamodels.py#L29
6. Databricks workflow:
https://github.com/apache/airflow/blob/728079af9b0e0fe60b44b27e34debfce10e249c6/providers/databricks/src/airflow/providers/databricks/plugins/databricks_workflow.py#L25
So we will have to unfortunately have it be a real class
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
