amoghrajesh commented on code in PR #60776:
URL: https://github.com/apache/airflow/pull/60776#discussion_r2719682166
##########
providers/databricks/src/airflow/providers/databricks/plugins/databricks_workflow.py:
##########
@@ -298,7 +298,7 @@ def xcom_key(self) -> str:
"""XCom key where the link is stored during task execution."""
return "databricks_job_run_link"
- def get_link(
+ def get_link( # type: ignore[override] # Signature intentionally kept
this way for Airflow 2.x compatibility
Review Comment:
Guess this is what's happening.
Earlier, baseoperatorlink.py was getting typing this way:
```python
if TYPE_CHECKING:
from airflow.models.taskinstancekey import TaskInstanceKey
def get_link(self, operator: BaseOperator, *, ti_key: TaskInstanceKey) ->
str:
```
Now it is:
```python
if TYPE_CHECKING:
from airflow.sdk.types import TaskInstanceKey
def get_link(self, operator: BaseOperator, *, ti_key: TaskInstanceKey) ->
str:
```
Earlier it didn't catch it because the types matched i presume, now since
the types do not match, it cascades into more issues. My changes somehow made
mypy stricter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
