stegololz commented on PR #61351:
URL: https://github.com/apache/airflow/pull/61351#issuecomment-3852642441

   > Thanks for the PR @stegololz! Looks good! I cannot see 
[c6eb21e](https://github.com/apache/airflow/commit/c6eb21e00bcc891db3ba04271779388a9f4d667a)
 in the PR that you mentioned includes CLI changes. Are you planning to create 
another PR for CLI? I would suggest to please include into this PR so there 
would be a clear connectionwith the current implementation, as I see `+7 -2` 
only, which is not high. Could you please also check the tests? It fails for 
permission in Python 3.10 and in some others 
https://github.com/apache/airflow/actions/runs/21682494606/job/62540136484?pr=61351
 I would still like to get @o-nikolas's and @vincbeck's take on the multi-team 
approach, when you have time
   
   Thanks for the review! Vincent already pointed you to the other other and 
the issue. 
   About the tests, last commit fix them locally, and the last rebase should be 
enough for the static checks. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to