xBis7 commented on code in PR #56150:
URL: https://github.com/apache/airflow/pull/56150#discussion_r2771071982
##########
shared/observability/src/airflow_shared/observability/metrics/otel_logger.py:
##########
@@ -387,28 +437,32 @@ def get_otel_logger(
stat_name_handler: Callable[[str], str] | None = None,
statsd_influxdb_enabled: bool = False,
) -> SafeOtelLogger:
- effective_service_name: str = service_name or "airflow"
+ otel_env_config = load_metrics_env_config()
+
+ effective_service_name: str = otel_env_config.service_name or service_name
Review Comment:
Initially, I removed the `airflow` fallback because the config already has
`Airflow` as the default.
Now with @jason810496's changes, default properties are not set for
deprecated configs and `service_name` has been marked as deprecated in favor of
`OTEL_SERVICE_NAME`.
Since the airflow config is going to be removed, it makes sense to skip
falling back to `airflow`. The thing is that I don't know if this is a breaking
change for some people.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
