xBis7 commented on code in PR #56150:
URL: https://github.com/apache/airflow/pull/56150#discussion_r2771086140
##########
shared/observability/src/airflow_shared/observability/traces/otel_tracer.py:
##########
@@ -142,9 +146,9 @@ def start_span(
links=None,
start_time=None,
):
- """Start a span; if service_name is not given, otel_service is used."""
- if component is None:
- component = self.otel_service
+ """Start a span."""
+ # Common practice is to use the module name.
+ component = component or __name__
Review Comment:
If people are filtering based on the old component name, then yes it can be.
Everyone I know is currently using Statsd but it's better to be safe than
sorry. I think you are right and we should do a deprecation process.
Do you have any example reference to what I should do for deprecating it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
