jscheffl commented on code in PR #61491:
URL: https://github.com/apache/airflow/pull/61491#discussion_r2771297621
##########
airflow-core/src/airflow/migrations/versions/0033_3_0_0_add_tables_for_backfill.py:
##########
@@ -49,7 +48,7 @@ def upgrade():
sa.Column("dag_id", sa.String(length=250), nullable=False),
sa.Column("from_date",
airflow.utils.sqlalchemy.UtcDateTime(timezone=True), nullable=False),
sa.Column("to_date",
airflow.utils.sqlalchemy.UtcDateTime(timezone=True), nullable=False),
- sa.Column("dag_run_conf", sqlalchemy_jsonfield.jsonfield.JSONField(),
nullable=False),
Review Comment:
I am also not a fan of adjusting old migration scripts and a bit of risk is
included that something breaks. But in this case it is a typing related change
and the content before+after should be the same. As explained ^^^is it all
consistenty executed with the new SW. so I think there is no harm.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
