guan404ming commented on code in PR #61366:
URL: https://github.com/apache/airflow/pull/61366#discussion_r2773736376
##########
airflow-core/src/airflow/ui/src/components/Clear/TaskInstance/ClearTaskInstanceDialog.tsx:
##########
@@ -63,7 +63,7 @@ const ClearTaskInstanceDialog = ({ onClose: onCloseDialog,
open: openDialog, tas
const upstream = selectedOptions.includes("upstream");
const downstream = selectedOptions.includes("downstream");
const [runOnLatestVersion, setRunOnLatestVersion] = useState(false);
- const [preventRunningTask, setPreventRunningTask] = useState(true);
+ const [preventRunningTask, setPreventRunningTask] = useState(false);
Review Comment:
- Line 66: State initialized to true
- Line 186: Checkbox renders checked={preventRunningTask} → checkbox starts
checked
- Line 231: API sends { prevent_running_task: true } only when state is
truthy
All three are in sync. State is true → checkbox shows checked → API sends
the flag. I think there is no inconsistency, could you please help confirm
this? Feel free to correct me if I'm wrong. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
