guan404ming commented on code in PR #61366:
URL: https://github.com/apache/airflow/pull/61366#discussion_r2778858861
##########
airflow-core/src/airflow/ui/src/components/Clear/TaskInstance/ClearTaskInstanceDialog.tsx:
##########
@@ -63,7 +63,7 @@ const ClearTaskInstanceDialog = ({ onClose: onCloseDialog,
open: openDialog, tas
const upstream = selectedOptions.includes("upstream");
const downstream = selectedOptions.includes("downstream");
const [runOnLatestVersion, setRunOnLatestVersion] = useState(false);
- const [preventRunningTask, setPreventRunningTask] = useState(true);
+ const [preventRunningTask, setPreventRunningTask] = useState(false);
Review Comment:
This change still seems unrelated to the i18n fix. Changing the default
value of preventRunningTask from true to false alters the behavior of the Clear
Task Instance dialog, which is outside the scope of this PR. I'd suggest either
reverting this line or splitting it into a separate PR with an explanation for
why the default should change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
