jason810496 commented on code in PR #61439:
URL: https://github.com/apache/airflow/pull/61439#discussion_r2776807723
##########
providers/hashicorp/src/airflow/providers/hashicorp/hooks/vault.py:
##########
@@ -376,6 +402,8 @@ def get_connection_form_widgets(cls) -> dict[str, Any]:
"kubernetes_jwt_path": StringField(
lazy_gettext("Kubernetes jwt path"),
widget=BS3TextFieldWidget()
),
+ "jwt_role": StringField(lazy_gettext("JWT role"),
widget=BS3TextFieldWidget()),
Review Comment:
`jwt_token` is missing I think.
```suggestion
"jwt_role": StringField(lazy_gettext("JWT role"),
widget=BS3TextFieldWidget()),
"jwt_token": StringField(lazy_gettext("JWT token"),
widget=BS3TextFieldWidget()),
```
##########
providers/hashicorp/src/airflow/providers/hashicorp/_internal_client/vault_client.py:
##########
@@ -82,6 +84,7 @@ class _VaultClient(LoggingMixin):
:param kubernetes_role: Role for Authentication (for ``kubernetes``
auth_type).
:param kubernetes_jwt_path: Path for kubernetes jwt token (for
``kubernetes`` auth_type, default:
``/var/run/secrets/kubernetes.io/serviceaccount/token``).
+ default: ``/var/run/secrets/kubernetes.io/serviceaccount/token``).
Review Comment:
It seems this line should move to line 101 as we had already doc the default
path for `kubernetes_jwt_path` in line 86, but we're still missing the default
value doc for `jwt_token_path` in line 101.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
