piotrlinski commented on code in PR #61439:
URL: https://github.com/apache/airflow/pull/61439#discussion_r2780985809
##########
providers/hashicorp/src/airflow/providers/hashicorp/_internal_client/vault_client.py:
##########
@@ -82,6 +84,7 @@ class _VaultClient(LoggingMixin):
:param kubernetes_role: Role for Authentication (for ``kubernetes``
auth_type).
:param kubernetes_jwt_path: Path for kubernetes jwt token (for
``kubernetes`` auth_type, default:
``/var/run/secrets/kubernetes.io/serviceaccount/token``).
+ default: ``/var/run/secrets/kubernetes.io/serviceaccount/token``).
Review Comment:
the default jwt token file path, is removed, the JWT is more generic auth
method, there is no standard for the default locations for tokens. Previously I
set it similar as for jwt token path like in kubernetes pods, this is not the
case here. The logic now goes, you need to set or token ot token path, there
are not defaults
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
