jason810496 commented on code in PR #61531:
URL: https://github.com/apache/airflow/pull/61531#discussion_r2778869231
##########
airflow-core/src/airflow/triggers/base.py:
##########
@@ -63,6 +63,8 @@ class BaseTrigger(abc.ABC, LoggingMixin):
let them be re-instantiated elsewhere.
"""
+ uses_triggerer_queue: bool = True
Review Comment:
How about renaming as `supports_triggerer_queue` to align `BaseExecutor`?
https://github.com/apache/airflow/blob/a11ec7296ce52ae3693e46835a49d8c5e3677341/airflow-core/src/airflow/executors/base_executor.py#L145-L146
##########
task-sdk/src/airflow/sdk/execution_time/task_runner.py:
##########
@@ -1097,9 +1095,9 @@ def _defer_task(
classpath, trigger_kwargs = defer.trigger.serialize()
queue: str | None = None
# Currently, only task-associated BaseTrigger instances may have a
non-None queue,
- # and only when triggerer.queues_enabled is True.
- if not isinstance(defer.trigger, (BaseEventTrigger, CallbackTrigger)) and
conf.getboolean(
- "triggerer", "queues_enabled", fallback=False
+ # and only when triggerer.queues_enabled conf is True.
+ if conf.getboolean("triggerer", "queues_enabled", fallback=False) and
getattr(
+ defer.trigger, "uses_triggerer_queue", True
Review Comment:
Should we fallback as `False` if `uses_triggerer_queue` not found ?
```suggestion
defer.trigger, "uses_triggerer_queue", False
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
