amoghrajesh commented on code in PR #61531:
URL: https://github.com/apache/airflow/pull/61531#discussion_r2779176292
##########
task-sdk/src/airflow/sdk/execution_time/task_runner.py:
##########
@@ -1097,9 +1095,9 @@ def _defer_task(
classpath, trigger_kwargs = defer.trigger.serialize()
queue: str | None = None
# Currently, only task-associated BaseTrigger instances may have a
non-None queue,
- # and only when triggerer.queues_enabled is True.
- if not isinstance(defer.trigger, (BaseEventTrigger, CallbackTrigger)) and
conf.getboolean(
- "triggerer", "queues_enabled", fallback=False
+ # and only when triggerer.queues_enabled conf is True.
+ if conf.getboolean("triggerer", "queues_enabled", fallback=False) and
getattr(
+ defer.trigger, "uses_triggerer_queue", True
Review Comment:
I retained the original behaviour. Earlier it checked for:
- Trigger is NOT BaseEventTrigger AND NOT CallbackTrigger
Now the logic does this:
- BaseEventTrigger.uses_triggerer_queue = False
- CallbackTrigger.uses_triggerer_queue = False
- BaseTrigger.uses_triggerer_queue = True (default for all other triggers)
Hence BaseEventTrigger and CallbackTrigger won't have triggers and ALL
others will have it. Same as original logic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
