yuseok89 commented on code in PR #61284:
URL: https://github.com/apache/airflow/pull/61284#discussion_r2787742807
##########
providers/google/src/airflow/providers/google/cloud/transfers/calendar_to_gcs.py:
##########
@@ -159,9 +174,9 @@ def _upload_data(
object_name=dest_file_name,
filename=temp_file.name,
)
- return dest_file_name
+ return f"gs://{self.destination_bucket}/{dest_file_name}"
Review Comment:
@shahar1
Just a question. Both `unwrap_single` and the suggested `return_gcs_uri`
flag seem to exist mainly to avoid breaking changes. Would it make sense to
consolidate them into a single flag in this case? Or do you prefer keeping both
flags for clarity and consistency with other operators?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
