Ajay9704 commented on code in PR #61284:
URL: https://github.com/apache/airflow/pull/61284#discussion_r2788420514
##########
providers/google/src/airflow/providers/google/cloud/transfers/calendar_to_gcs.py:
##########
@@ -159,9 +174,9 @@ def _upload_data(
object_name=dest_file_name,
filename=temp_file.name,
)
- return dest_file_name
+ return f"gs://{self.destination_bucket}/{dest_file_name}"
Review Comment:
> I went over the PR again and noticed that changing the returned value from
`dest_file_name` to the full URI could be a breaking change, so we should
deprecate it slowly (similar to the `unwrap_single=False`). Add another flag
`return_gcs_uri` with `False` as default. Only if `unwrap_single` is also
`False`, it should return `dest_file_name`. `return_gcs_uri` cannot be set to
`True` altogether with `unwrap_single=True` (it should raise `ValueError`, as
in the future we plan to align all operators with returning list of URIs.
Please handle these case, including unit tests.
@shahar1 All requested changes have been implemented and pushed.
Please review when you have time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
