jscheffl commented on code in PR #61812:
URL: https://github.com/apache/airflow/pull/61812#discussion_r2814243648
##########
providers/edge3/src/airflow/providers/edge3/worker_api/routes/jobs.py:
##########
@@ -87,8 +87,6 @@ def fetch(
# Edge worker does not backport emitted Airflow metrics, so export some
metrics
tags = {"dag_id": job.dag_id, "task_id": job.task_id, "queue": job.queue}
try:
- from airflow.sdk._shared.observability.metrics.dual_stats_manager
import DualStatsManager
-
DualStatsManager.incr("edge_worker.ti.start", tags=tags)
Review Comment:
The `# use next version` marker is to ensure the dependency of efge3 is
increased once _both_ providers are released to ensure that what you see in
main today will be consistent after release. Common compat will render a new
version number and then after this is increased the dependency of edge3 will be
updated. This ensures that edge will not work with older common compat.
Which TLDR means you do not need to consider some backwards compatibility to
common compat.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
