YoannAbriel opened a new pull request, #63207:
URL: https://github.com/apache/airflow/pull/63207
## Problem
`TriggerDagRunOperator` crashes with `UnboundLocalError: cannot access local
variable 'state'` when targeting a non-existent DAG. The API server returns
404, which `SUPERVISOR_COMMS.send()` re-raises as `ServerResponseError` — but
this propagates past all exception handlers in `run()` into the `finally` block
where `state` was declared but never assigned.
## Root Cause
Two issues:
1. `state: TaskInstanceState` in `run()` is declared without a default
value. Any unhandled exception reaching the `finally` block causes
`UnboundLocalError` when accessing `state.value` for stats.
2. The `DagRunOperations.trigger()` client method only handles 409
(conflict) — a 404 from the API server is re-raised as `ServerResponseError`,
which isn't caught by `_handle_trigger_dag_run`.
## Fix
- Initialize `state = TaskInstanceState.FAILED` as a safe default so the
`finally` block always works, regardless of what exception propagates.
- Add `DAG_NOT_FOUND` to `ErrorType` enum.
- Handle 404 in `DagRunOperations.trigger()`, returning
`ErrorResponse(error=ErrorType.DAG_NOT_FOUND)`.
- Handle `DAG_NOT_FOUND` in `_handle_trigger_dag_run`, failing the task
gracefully instead of crashing.
Tests added for both the client-side 404 handling and the task runner
DAG-not-found path.
Closes: #63089
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
---
##### Was generative AI tooling used to co-author this PR?
- [X] Yes — Claude Code
Generated-by: Claude Code following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
