jscheffl commented on code in PR #62343:
URL: https://github.com/apache/airflow/pull/62343#discussion_r2970084882
##########
airflow-core/src/airflow/api_fastapi/core_api/routes/public/connections.py:
##########
@@ -257,6 +286,83 @@ def test_connection(test_body: ConnectionBody) ->
ConnectionTestResponse:
os.environ.pop(conn_env_var, None)
+@connections_router.post(
Review Comment:
This is the API that is submitted by UI to queue a test task? I am not sure
if we should add this to "public API" because I think we should rather expose
this to UI only... and keep it a private API. Once reason is that I assume we
don't need to have this for external integrations (If I automatically add
connections most probably I have tested them before...) as well as (2) this
would be a documented exposure that somebody uses this as a door to DDos
workload?
Also this would make it harder to change it if it is public... then it is a
commiment to keep it stable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
