anishgirianish commented on code in PR #62343:
URL: https://github.com/apache/airflow/pull/62343#discussion_r2971228498
##########
airflow-core/src/airflow/api_fastapi/core_api/routes/public/connections.py:
##########
@@ -257,6 +286,83 @@ def test_connection(test_body: ConnectionBody) ->
ConnectionTestResponse:
os.environ.pop(conn_env_var, None)
+@connections_router.post(
Review Comment:
Hi @jscheffl, thank you for raising this. It's a valid concern. I wanted to
note that the existing sync POST /connections/test route is already in the
public API with the same test_connection=Enabled guard and auth. Moving only
the async version to UI-only would create an inconsistency where external
clients could test synchronously but not asynchronously. Would you prefer both
routes to be public (consistent with current state), both moved to UI-only, or
is there something specific about the async route that warrants different
treatment? Happy to go whichever direction you think is best. Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
