wjddn279 commented on code in PR #64143:
URL: https://github.com/apache/airflow/pull/64143#discussion_r2986052880
##########
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/kube_config.py:
##########
@@ -89,9 +89,7 @@ def __init__(self, executor_conf: ExecutorConf | None = None):
# create, watch, get, and delete pods in this namespace.
self.kube_namespace = self._conf.get(self.kubernetes_section,
"namespace")
self.multi_namespace_mode =
self._conf.getboolean(self.kubernetes_section, "multi_namespace_mode")
- multi_ns_list = self._conf.get(
- self.kubernetes_section, "multi_namespace_mode_namespace_list",
fallback=""
- )
+ multi_ns_list = self._conf.get(self.kubernetes_section,
"multi_namespace_mode_namespace_list")
Review Comment:
In this [PR](https://github.com/apache/airflow/pull/62696),
`airflow.sdk.configuration` was updated to also read from
`provider_config_fallback_defaults.cfg` and populate the default values. I
removed the fallback since, outside of tests, the default values will be read
from `provider.yaml`, making the fallback unnecessary.
@jason810496 I'm a bit confused about the scope of the changes. I removed
the fallback only for the values that exist in
`provider_config_fallback_defaults.cfg` — is that correct? Or should I just
leave them as they were?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
