jason810496 commented on code in PR #64143:
URL: https://github.com/apache/airflow/pull/64143#discussion_r2994938520
##########
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/kube_config.py:
##########
@@ -89,9 +89,7 @@ def __init__(self, executor_conf: ExecutorConf | None = None):
# create, watch, get, and delete pods in this namespace.
self.kube_namespace = self._conf.get(self.kubernetes_section,
"namespace")
self.multi_namespace_mode =
self._conf.getboolean(self.kubernetes_section, "multi_namespace_mode")
- multi_ns_list = self._conf.get(
- self.kubernetes_section, "multi_namespace_mode_namespace_list",
fallback=""
- )
+ multi_ns_list = self._conf.get(self.kubernetes_section,
"multi_namespace_mode_namespace_list")
Review Comment:
If the existing value for `fallback` is same as the value in `provider.yaml`
and in `provider_config_fallback_defaults, then we can safely remove the
`fallback`.
But if not fulfill any one of the above default value, then I will suggest
to keep it as it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
