eladkal commented on code in PR #64519:
URL: https://github.com/apache/airflow/pull/64519#discussion_r3013905458
##########
providers/salesforce/src/airflow/providers/salesforce/operators/bulk.py:
##########
@@ -46,6 +47,9 @@ class SalesforceBulkOperator(BaseOperator):
:param batch_size: number of records to assign for each batch in the job
:param use_serial: Process batches in serial mode
:param salesforce_conn_id: The :ref:`Salesforce Connection id
<howto/connection:salesforce>`.
+ :param raise_on_failures: If True, raise an
:class:`~airflow.exceptions.AirflowException` when
+ any record in the result set reports ``success=False``. Defaults to
``False`` for backward
+ compatibility — failures are always logged as warnings regardless of
this setting.
Review Comment:
This open the door to so many customizations that we won't be able to
accommodate.
For example - your use case is yes/no - even a single error will be raised.
What if for someone else the desired logic will be threshold? say X out of the
total? There can be so many customized logics.
I tend to say that this feature should be kept in your local deployment
rather than be served from the project code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
