nagasrisai commented on code in PR #64519:
URL: https://github.com/apache/airflow/pull/64519#discussion_r3019570163
##########
providers/salesforce/src/airflow/providers/salesforce/operators/bulk.py:
##########
@@ -46,6 +47,9 @@ class SalesforceBulkOperator(BaseOperator):
:param batch_size: number of records to assign for each batch in the job
:param use_serial: Process batches in serial mode
:param salesforce_conn_id: The :ref:`Salesforce Connection id
<howto/connection:salesforce>`.
+ :param raise_on_failures: If True, raise an
:class:`~airflow.exceptions.AirflowException` when
+ any record in the result set reports ``success=False``. Defaults to
``False`` for backward
+ compatibility — failures are always logged as warnings regardless of
this setting.
Review Comment:
That is a fair point and I agree with you. The `raise_on_failures` parameter
was probably overreach on my part since you could reasonably want threshold
logic, partial-failure tolerance, or all sorts of custom handling once you open
that door.
I am happy to drop that parameter entirely. The part I would like to keep is
the logging: right now if every record comes back with `success=False` the task
shows green and produces no output other than the raw XCom value. Just logging
a warning that says how many records failed and what the Salesforce error codes
were seems clearly useful without adding any policy footprint. Would you be OK
with a version that removes `raise_on_failures` and only adds the failure
logging?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
