potiuk commented on PR #63889: URL: https://github.com/apache/airflow/pull/63889#issuecomment-4169580216
@Suraj-kumar00 This PR has a few issues that need to be addressed before it can be reviewed — please see our [Pull Request quality criteria](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-quality-criteria). **Issues found:** - :warning: **Title quality**: The PR title 'Feat/task instance cli support' is a branch-name pattern rather than a properly written PR title. While it does convey the general intent, the slash-separated format ('Feat/...') is unconventional and the wording is terse. A title like 'Add task instance management commands to airflowctl CLI' would be clearer and more consistent with project norms. - :warning: **Code quality — pointless try/except blocks**: In `operations.py`, the `get`, `clear`, and `update` methods all follow the pattern `try: ... except ServerResponseError as e: raise e`. A bare re-raise of the caught exception adds no value — it is identical to having no try/except at all. This is a common AI-generated code smell ('narrating' or boilerplate patterns) and should be removed. **What to do next:** - The comment informs you what you need to do. - Fix each issue, then mark the PR as "Ready for review" in the GitHub UI - but only after making sure that all the issues are fixed. - There is no rush — take your time and work at your own pace. We appreciate your contribution and are happy to wait for updates. - Maintainers will then proceed with a normal review. There is no rush — take your time and work at your own pace. We appreciate your contribution and are happy to wait for updates. If you have questions, feel free to ask on the [Airflow Slack](https://s.apache.org/airflow-slack). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
