bugraoz93 commented on code in PR #63889:
URL: https://github.com/apache/airflow/pull/63889#discussion_r3024424596
##########
airflow-ctl/src/airflowctl/ctl/cli_config.py:
##########
@@ -645,10 +655,21 @@ def _get_func(args: Namespace, api_operation: dict,
api_client: Client = NEW_API
datamodel_param_name = parameter_key
if expanded_parameter in self.excluded_parameters:
continue
- if expanded_parameter in args_dict.keys():
+ if (
+ expanded_parameter in args_dict.keys()
+ and args_dict[expanded_parameter] is not None
+ ):
+ val = args_dict[expanded_parameter]
Review Comment:
>Improved API field parsing to automatically convert comma-separated CLI
inputs into lists when required by Pydantic models (e.g. --task-ids t1,t2 →
["t1", "t2"])
I don't quite follow your changes here. This is not the input part of the
CLI. This part parses the Pydantic models from imported modules and files.
We should handle I/O in the link below. Because this is the only CLI part of
auto-generated commands with client-generated. We also handle output here if
you check there
https://github.com/bugraoz93/airflow/blob/ea552cb850b0e1ea66560197038d09608c7ef0b3/airflow-ctl/src/airflowctl/ctl/cli_config.py#L620-L666
##########
uv.lock:
##########
@@ -12,7 +12,7 @@ resolution-markers = [
]
[options]
-exclude-newer = "2026-03-27T13:44:39.000056016Z"
+exclude-newer = "2026-03-28T18:14:32.869345Z"
Review Comment:
Why has ' uv. lock ' been updated?
##########
airflow-ctl/src/airflowctl/api/client.py:
##########
@@ -415,6 +416,12 @@ def xcom(self):
"""Operations related to XComs."""
return XComOperations(self)
+ @lru_cache() # type: ignore[prop-decorator]
+ @property
+ def task_instances(self):
Review Comment:
Can we rename it to `tasks` to fit the current Airflow CLI to make
migrations easier?
`airflowctl tasks ...`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
