shivaam commented on PR #63657: URL: https://github.com/apache/airflow/pull/63657#issuecomment-4274945116
@ferruzzi Thanks for the review! I have updated the Pr and addressed all your comments. 1. Dropped the `cast()` wrappers and `isinstance(tuple)` guards now that #65392 is merged — `BaseExecutor` handles `WorkloadKey` natively and skips callback keys in `log_task_event` internally. Removed the unused `cast` import and one test whose coverage moved to airflow-core. 2. Renamed the `_process_workloads` param to `workload_items` so the module import no longer needs `as wl`. 3. Renamed the task-named methods and `pending_tasks` to their workload equivalents. Straight rename, no compat shim — matches the pattern from the merged Lambda callback PR. Happy to add shims if you'd prefer to diverge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
