ferruzzi commented on code in PR #63657:
URL: https://github.com/apache/airflow/pull/63657#discussion_r3114111240


##########
providers/amazon/src/airflow/providers/amazon/aws/executors/ecs/ecs_executor.py:
##########
@@ -55,6 +55,7 @@
     from sqlalchemy.orm import Session
 
     from airflow.executors import workloads
+    from airflow.executors.workloads.types import WorkloadKey

Review Comment:
   This will need to be wrapped in a version check.  The user could be running 
latest provider package with core 3.0 and this will blow up.  It'll be 
something like 
   
   ```python
   if TYPE_CHECKING:
       if AIRFLOW_V_3_3_PLUS:
           from airflow.executors.workloads.types import WorkloadKey
       else:
           WorkloadKey: TypeAlias = TaskInstanceKey  # type: ignore[no-redef, 
misc]
   
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to