SameerMesiah97 commented on PR #63035:
URL: https://github.com/apache/airflow/pull/63035#issuecomment-4276695432
> Also @SameerMesiah97 Have you done any manual QA? Actually running the
executor with some tasks and callbacks with these changes?
I have just tested the following DAG with a live cloud deployment using the
`AwsLambdaExecutor`:
```
from datetime import datetime
from airflow import DAG
from airflow.operators.bash import BashOperator
def success_callback(context):
print("Callback executed! Task succeeded.")
print(f"Task: {context['task_instance_key_str']}")
with DAG(
dag_id="lambda_executor_smoke",
start_date=datetime(2024, 1, 1),
schedule=None,
catchup=False,
) as dag:
test_task = BashOperator(
task_id="test_task",
bash_command="echo 'Hello from Lambda Executor' && exit 0",
on_success_callback=success_callback
)
```
I can verify that both the task and callback executed successfully via the
UI and the Cloudwatch logs.
> This looks close now! Just one more comment from me. Then I'm okay with
the changes. But @ferruzzi should have the final say since he is more aware of
the changes needed to support Callbacks.
Note that the above test was carried out before a new set of changes I will
push now to address your feedback and accomodate changes in PR #65392.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
