SameerMesiah97 commented on code in PR #63035:
URL: https://github.com/apache/airflow/pull/63035#discussion_r3114484953
##########
providers/amazon/src/airflow/providers/amazon/aws/executors/aws_lambda/lambda_executor.py:
##########
@@ -202,90 +212,150 @@ def sync(self):
"AWS credentials are either missing or expired:
%s.\nRetrying connection", error
)
except Exception:
- self.log.exception("An error occurred while syncing tasks")
+ self.log.exception("An error occurred while syncing workloads.")
- def queue_workload(self, workload: workloads.All, session: Session | None)
-> None:
- from airflow.executors import workloads
+ def queue_workload(
Review Comment:
@ferruzzi
I added the below. I believe it should be `workload.callback.id` instead of
`workload.callback.key`. I am leaving this so that others are aware.
```
# TODO: Remove this once the minimum supported version is 3.2+, and defer
to BaseExecutor.queue_workload.
def queue_workload(self, workload: workloads.All, session: Session |
None) -> None:
from airflow.executors import workloads
if isinstance(workload, workloads.ExecuteTask):
self.queued_tasks[workload.ti.key] = workload
return
if AIRFLOW_V_3_3_PLUS and isinstance(workload,
workloads.ExecuteCallback):
self.queued_callbacks[workload.callback.id] = workload
return
raise RuntimeError(f"{type(self)} cannot handle workloads of type
{type(workload)}")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
