ShaharAviram1 opened a new pull request, #65730:
URL: https://github.com/apache/airflow/pull/65730
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
This PR updates `airflow-core/src/airflow/ui/tests/e2e/pages/XComsPage.ts`
to use more idiomatic Playwright assertions and remove a few non-retrying or
redundant checks. No changes were made to `xcoms.spec.ts`.
related: #63966
Changes made:
- Replaced manual `textContent()` checks inside `toPass` blocks with
retrying locator assertions using `expect(locator).not.toBeEmpty()` in:
- `verifyXComDetailsDisplay`
- `verifyXComValuesDisplayed`
- Removed a redundant `count()` assertion in:
- `verifyXComsExist`
- Replaced snapshot-style row count assertions with retrying locator
assertions using `await expect(rows).not.toHaveCount(0)` in:
- `verifyDagDisplayNameFiltering`
- `verifyKeyPatternFiltering`
Validation:
- `pnpm exec tsc --noEmit`
- `pnpm exec playwright test tests/e2e/specs/xcoms.spec.ts --list` returns 0
tests, which is expected because `xcoms.spec.ts` is currently listed in
`testIgnore` in `playwright.config.ts` as part of existing stabilization work.
-->
---
##### Was generative AI tooling used to co-author this PR?
- [X] Yes — Claude Sonnet 4.6
Generated-by: Claude Sonnet 4.6 following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
