nathadfield commented on PR #63884:
URL: https://github.com/apache/airflow/pull/63884#issuecomment-4336842097
Thanks @pierrejeambrun for the thorough review! All addressed:
- Hook refactored to the nullable-override pattern. Dropped the `useEffect`,
`useRef`, and the "value is undefined until config loads" intermediate state.
The value is now just `override ?? dagLevelConfig ?? globalConfigValue ??
fallback`.
- `RunBackfillForm` now uses `useForm({ values, resetOptions: {
keepDirtyValues: true } })` instead of `useEffect + setValue`. Re-syncs the
resolved default reactively while preserving any user-dirty fields.
- `?? undefined` removed. Was a no-op since field.value is boolean after the
form change.
- Docs precedence table updated to mirror the newsfragment phrasing: `False`
for clear/rerun, `True` for backfills.
- Test imports moved to module level.
- End-to-end test added:
`test_clear_endpoint_invokes_resolver_when_field_omitted` hits
`/dagRuns/{id}/clear` with no `run_on_latest_version` and asserts the resolver
gets called with None.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
