potiuk commented on code in PR #64012: URL: https://github.com/apache/airflow/pull/64012#discussion_r3172265019
########## .agents/skills/stage-changes/SKILL.md: ########## @@ -0,0 +1,72 @@ +<!-- SPDX-License-Identifier: Apache-2.0 + https://www.apache.org/licenses/LICENSE-2.0 --> + +<!-- markdownlint-disable MD022 --> +--- +name: stage-changes +description: Stage changed files for commit using git add. This is a host-only operation — it must never run inside a Breeze container. +--- +<!-- markdownlint-enable MD022 --> + +Stage Changes +============= + +Stage specific files or directories before running static checks or committing. + +Source of truth for contribution workflow order is `contributing-docs`; this skill +enforces the host/container guardrails when applying that workflow. + +Host-Only Guardrail +------------------- + +This skill operates on the **host** working tree. Running `git` commands inside a +Breeze container will silently operate on container-local paths that differ from your +actual working tree. + +**Before running:** Confirm you are on the host by checking: + +- `/.dockerenv` does **not** exist Review Comment: Also I think this all should be tested with `devcontainer` setup. In devcontainer, we use `breeze ci` built image - but by definition the devcontainers run inside container - so likely there is no good way to exit from it ? I am not sure if agents work with devcontainers and how - but I think this scenario should be tested what if someone uses devcontainers (say codespaces, but also VSCode and IntelliJ have built-in devcontainer support and some people might opt to choose it. I believe in Dev container setup, all the sources - including .git are mounted to the container - and genereally speaking `git` should work there. however of course devil is in details - things like authentication and (especially nowadays with agents and `claude -w` or generally using. worktrees (which finally got used a lot thanks to agentic workflows) - I am not sure how it works with devcontainers. It shoudl be definitely checked and ideally we should bave more complete scenarios describing the different workflows - including worktrees and devcontainers. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
