potiuk commented on code in PR #64012: URL: https://github.com/apache/airflow/pull/64012#discussion_r3172283101
########## scripts/ci/prek/breeze_context.py: ########## @@ -0,0 +1,291 @@ +# Licensed to the Apache Software Foundation (ASF) under one Review Comment: Learning more about agents - I am not sure if we **need** that - also I think detection of BREEZE should be far easier - just presence of `BREEZE` env variable should be enough I think - with the devcontainer case handled in a special way I guess - also we have full control over what variables are set in BREEZE and devcontainer - and in case we need it - we can very easily add new variables, to differentiate. I am not sure why we would have to run this python script to detect breeze. I guess something like that would work reliably: > To detect if you are in breeze check if `BREEZE` variable is set That should be quite enough for agent to detect where it is. Or am I missing something ? Why would we complicate it like that? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
