FTS18 commented on PR #66230: URL: https://github.com/apache/airflow/pull/66230#issuecomment-4363766184
I have updated the PR to address all feedback from @kaxil: * **Root Cause Fix**: Updated `_showwarning` in `structlog.py` to explicitly pass `process` and `thread` information during warning redirection. This ensures real diagnostic data is preserved for all renderers (including JSON). * **Live Fallbacks**: Updated `PercentFormatRender` to use `os.getpid()` and `threading.get_ident()` as fallbacks for missing or unknown callsite parameters instead of returning `0`. * **Test Consolidation**: Moved and improved the regression tests into `test_percent_formatter.py` with descriptive names and deterministic mocks. Deleted the standalone test file. * **Newsfragment**: Recreated the newsfragment with plain UTF-8 encoding (no BOM) and LF line endings. Updated the wording to focus on the user-visible symptom. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
