parkhojeong commented on code in PR #66274:
URL: https://github.com/apache/airflow/pull/66274#discussion_r3177657063
##########
airflow-core/src/airflow/ui/public/i18n/locales/ko/dag.json:
##########
@@ -40,6 +40,16 @@
"parseDuration": "파싱 기간:",
"parsedAt": "파싱 시간:"
},
+ "deadlineAlerts": {
+ "completionRule": "{{reference}} 기준 {{interval}} 이내에 완료되어야 합니다",
+ "count_one": "마감 {{count}}건",
+ "count_other": "마감 {{count}}건",
Review Comment:
```suggestion
"count_one": "마감 {{count}}개",
"count_other": "마감 {{count}}개",
```
the key for `count` already uses '개'(`logs.search.matchCount`: ).
`개` is better for consistency
##########
airflow-core/src/airflow/ui/public/i18n/locales/ko/dag.json:
##########
@@ -40,6 +40,16 @@
"parseDuration": "파싱 기간:",
"parsedAt": "파싱 시간:"
},
+ "deadlineAlerts": {
+ "completionRule": "{{reference}} 기준 {{interval}} 이내에 완료되어야 합니다",
+ "count_one": "마감 {{count}}건",
+ "count_other": "마감 {{count}}건",
Review Comment:
```suggestion
"count_one": "마감 {{count}}개",
"count_other": "마감 {{count}}개",
```
the key for `count` already uses '개'(`logs.search.matchCount`).
`개` is better for consistency
##########
airflow-core/src/airflow/ui/public/i18n/locales/ko/dag.json:
##########
@@ -40,6 +40,16 @@
"parseDuration": "파싱 기간:",
"parsedAt": "파싱 시간:"
},
+ "deadlineAlerts": {
+ "completionRule": "{{reference}} 기준 {{interval}} 이내에 완료되어야 합니다",
+ "count_one": "마감 {{count}}건",
+ "count_other": "마감 {{count}}건",
Review Comment:
```suggestion
"count_one": "마감 {{count}}개",
"count_other": "마감 {{count}}개",
```
the key for `count` already uses '개'(`logs.search.matchCount`)
`개` is better for consistency
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
