kkumtree commented on code in PR #66274:
URL: https://github.com/apache/airflow/pull/66274#discussion_r3181368694
##########
airflow-core/src/airflow/ui/public/i18n/locales/ko/dag.json:
##########
@@ -40,6 +40,16 @@
"parseDuration": "파싱 기간:",
"parsedAt": "파싱 시간:"
},
+ "deadlineAlerts": {
+ "completionRule": "{{reference}} 기준 {{interval}} 이내에 완료되어야 합니다",
+ "count_one": "마감 {{count}}건",
+ "count_other": "마감 {{count}}건",
+ "referenceType": {
+ "AverageRuntimeDeadline": "평균 실행 시간",
+ "DagRunLogicalDateDeadline": "논리적 실행 날짜",
+ "DagRunQueuedAtDeadline": "대기열에 등록된 시각"
Review Comment:
> Suggested change
> "DagRunLogicalDateDeadline": "논리적 실행 날짜",
> "DagRunQueuedAtDeadline": "대기열에 등록된 시각"
> "DagRunLogicalDateDeadline": "논리적 날짜",
> "DagRunQueuedAtDeadline": "대기열에 등록된 시각"
> You do not have permission to apply this suggestion.
> `DagRunLogicalDateDeadline` means "logical date for deadline" not "logical
run date for deadline" . en/dag.json uses "logical date" it seems that you
consider word `run` in `DagRun` .
>
> [@kkumtree](https://github.com/kkumtree) said `How about using 논리적 날짜 for
.DagRunQueuedAtDeadline?`. This matches my suggestion. (
DagRunLogicalDateDeadline may be correct instead of DagRunQueuedAtDeadline. it
looks just mistake) [#66274
(comment)](https://github.com/apache/airflow/pull/66274#issuecomment-4363819426)
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
