SameerMesiah97 commented on code in PR #64051:
URL: https://github.com/apache/airflow/pull/64051#discussion_r3178589201
##########
providers/airbyte/tests/unit/airbyte/operators/test_airbyte.py:
##########
@@ -68,8 +68,15 @@ def test_execute(self, mock_wait_for_job,
mock_submit_sync_connection, create_co
job_id=self.job_id, wait_seconds=self.wait_seconds,
timeout=self.timeout
)
- @pytest.mark.parametrize("status", ["success", "cancelled"])
- def test_execute_complete_non_error_states(self, status,
create_connection_without_db):
+ @pytest.mark.parametrize(
+ ("status", "should_raise", "expected_message"),
+ [
+ (JobStatusEnum.SUCCEEDED, False, "Job Succeeded"),
+ (JobStatusEnum.CANCELLED, True, "Job Cancelled"),
Review Comment:
Please see my comment above. I believe cancellation should raise under the
current implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
