SameerMesiah97 commented on code in PR #64051:
URL: https://github.com/apache/airflow/pull/64051#discussion_r3178624962
##########
providers/airbyte/src/airflow/providers/airbyte/operators/airbyte.py:
##########
@@ -129,6 +144,22 @@ def execute_complete(self, context: Context, event: Any =
None) -> None:
self.log.debug("Error occurred with context: %s", context)
raise RuntimeError(event["message"])
+ if event["status"] == "cancelled":
+ self.log.debug("Job cancelled with context: %s", context)
+ raise RuntimeError(event["message"])
Review Comment:
I am not sure what you mean by this. If you look at the non-deferrable path,
it calls `hook.wait_for_job`, which has the following for cancellation:
```
if state == JobStatusEnum.CANCELLED:
raise AirflowException(f"Job was cancelled:\n{job}")
```
You will see that that an exception is in fact being raised when a normal
terminal state i.e. `CANCELLED` is being reached. The deferrable path is just
raising `RuntimeError` with a similar message to avoid introducing
`AirflowException`.
Please let me know what you think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
