choo121600 commented on code in PR #66058:
URL: https://github.com/apache/airflow/pull/66058#discussion_r3179331521
##########
airflow-core/src/airflow/ui/tests/e2e/pages/ConnectionsPage.ts:
##########
@@ -224,7 +225,10 @@ export class ConnectionsPage extends BasePage {
if (details.extra !== undefined && details.extra !== "") {
const extraAccordion = this.page.getByRole("button", { name: /extra
fields json/i });
- const accordionVisible = await extraAccordion.isVisible({ timeout: 5000
}).catch(() => false);
+ const accordionVisible = await extraAccordion
Review Comment:
Is there a specific reason for choosing `waitFor({ state: "visible",
timeout: 5000 })` over `isVisible({ timeout: 5000 })`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
