haseebmalik18 commented on code in PR #66058:
URL: https://github.com/apache/airflow/pull/66058#discussion_r3183383315
##########
airflow-core/src/airflow/ui/tests/e2e/pages/ConnectionsPage.ts:
##########
@@ -224,7 +225,10 @@ export class ConnectionsPage extends BasePage {
if (details.extra !== undefined && details.extra !== "") {
const extraAccordion = this.page.getByRole("button", { name: /extra
fields json/i });
- const accordionVisible = await extraAccordion.isVisible({ timeout: 5000
}).catch(() => false);
+ const accordionVisible = await extraAccordion
Review Comment:
`isVisible()` does accept a timeout param but [Playwright
ignores](https://playwright.dev/docs/api/class-locator#locator-is-visible) it
it always returns immediately without waiting. `waitFor()` actually waits up to
5s for the UI element to render
##########
airflow-core/src/airflow/ui/tests/e2e/pages/ConnectionsPage.ts:
##########
@@ -224,7 +225,10 @@ export class ConnectionsPage extends BasePage {
if (details.extra !== undefined && details.extra !== "") {
const extraAccordion = this.page.getByRole("button", { name: /extra
fields json/i });
- const accordionVisible = await extraAccordion.isVisible({ timeout: 5000
}).catch(() => false);
+ const accordionVisible = await extraAccordion
Review Comment:
`isVisible()` does accept a timeout param but [Playwright
ignores](https://playwright.dev/docs/api/class-locator#locator-is-visible) it
always returns immediately without waiting. `waitFor()` actually waits up to 5s
for the UI element to render
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
