junyeong0619 commented on code in PR #66022:
URL: https://github.com/apache/airflow/pull/66022#discussion_r3215498776
##########
airflow-core/src/airflow/api_fastapi/execution_api/routes/__init__.py:
##########
@@ -51,6 +51,7 @@
authenticated_router.include_router(
task_reschedules.router, prefix="/task-reschedules", tags=["Task
Reschedules"]
)
+authenticated_router.include_router(variables.keys_router,
prefix="/variables", tags=["Variables"])
Review Comment:
Merged `keys_router` into the same `router`, with `/keys` declared before
`/{variable_key:path}` in the same file so the static path always wins
regardless of `include_router` order.
The dependency `has_variable_access` was moved from router-level to
per-route on path-param routes.
##########
airflow-core/src/airflow/api_fastapi/execution_api/routes/variables.py:
##########
@@ -120,3 +125,25 @@ def delete_variable(
):
"""Delete an Airflow Variable."""
Variable.delete(key=variable_key, team_name=team_name)
+
+
+@keys_router.get(
Review Comment:
Added a `.. note::` block to the route docstring explaining the deliberate
bypass and the intentional asymmetry.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
