ferruzzi commented on PR #66022:
URL: https://github.com/apache/airflow/pull/66022#issuecomment-4425524447
Sorry I'm so late, I've been on vacation and just getting back. I love
this. Nice work! One gap: CallbackToSupervisor in callback_supervisor.py is a
separate union (GetConnection | GetVariable | MaskSecret) that controls what
the callback subprocess is allowed to send. This PR adds GetVariableKeys to
the other three supervisors but not to the callback subprocess.
If someone calls Variable.keys() inside a callback, the message will be
rejected by the decoder.
Could you add GetVariableKeys to the CallbackToSupervisor union and the
corresponding dispatch in CallbackSubprocess._handle_request? The shared
handler already exists so it's just two lines plus the import.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
