vatsrahul1001 commented on code in PR #66696:
URL: https://github.com/apache/airflow/pull/66696#discussion_r3217468437
##########
airflow-core/src/airflow/api_fastapi/common/parameters.py:
##########
@@ -908,17 +937,15 @@ def depends_datetime(
upper_bound_lt: datetime | None = Query(alias=f"{filter_name}_lt",
default=None),
) -> RangeFilter:
attr = getattr(model, attribute_name or filter_name)
- if filter_name in ("start_date", "end_date"):
- attr = func.coalesce(attr, func.now())
- return RangeFilter(
- Range(
- lower_bound_gte=lower_bound_gte,
- lower_bound_gt=lower_bound_gt,
- upper_bound_lte=upper_bound_lte,
- upper_bound_lt=upper_bound_lt,
- ),
- attr,
+ range_val = Range(
+ lower_bound_gte=lower_bound_gte,
+ lower_bound_gt=lower_bound_gt,
+ upper_bound_lte=upper_bound_lte,
+ upper_bound_lt=upper_bound_lt,
)
+ if filter_name in ("start_date", "end_date"):
Review Comment:
Here we are only resolving column by `filter_name`. We should do by
attribute_name or filter_name like we are doing above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
