amoghrajesh opened a new pull request, #66708:
URL: https://github.com/apache/airflow/pull/66708
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
http://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [ ] Yes (please specify the tool below)
<!--
Generated-by: [Tool Name] following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
Every call site in the execution API for task state and asset state passes
`session=session` to `get_state_backend().get/set/delete/clear(...)`. This is
required so the TI scope look-up and the state write share the same sqla
transaction, avoiding a race condition where the TI could be deleted between
the two operations (flagged in #66073). However, `BaseStateBackend` had no
`session` parameter — the calls only worked at runtime because
`@provide_session` on `MetastoreStateBackend` intercepts the kwarg. Any custom
backend would crash with `TypeError: unexpected keyword argument 'session'`.
### Current behaviour
All twelve state backend call sites carry `# type: ignore[call-arg]`
comments to silence mypy. A custom backend implementing `BaseStateBackend`
would raise `TypeError` at runtime the moment any route called
`get/set/delete/clear` on it.
### Proposed change
Adds `session: Session | None = None` to `get`, `set`, `delete`, and `clear`
on `BaseStateBackend`. The `Session` type is imported under `TYPE_CHECKING`
only, so there is no runtime SQLAlchemy dependency on the shared
`airflow_shared.state` library. All twelve `# type: ignore[call-arg]` comments
are removed.
**Alternatives considered:**
- *Remove `session=session` at call sites* — breaks transaction atomicity
between scope look-up and write (Kaxil's concern in #66073).
- *`**kwargs`* — completely opaque; mypy cannot help and custom backend
authors have no idea what can be passed.
- *`isinstance` check at every call site* — ugly, defeats the abstraction,
requires importing `MetastoreStateBackend` into route layer.
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
