amoghrajesh commented on code in PR #66708:
URL: https://github.com/apache/airflow/pull/66708#discussion_r3224866005
##########
shared/state/src/airflow_shared/state/__init__.py:
##########
@@ -106,7 +118,9 @@ async def aget(self, scope: StateScope, key: str) -> str |
None:
"""Async variant of get. Must handle both ``TaskScope`` and
``AssetScope``."""
@abstractmethod
- async def aset(self, scope: StateScope, key: str, value: str) -> None:
+ async def aset(
+ self, scope: StateScope, key: str, value: str, *, session: Session |
None = None
Review Comment:
Ah that's not correct.
Removed `session` from `aset` (it was there by mistake; the async path
always uses `create_session_async()` internally). Added a docstring note on the
async methods explaining they manage their own sessions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
