parkhojeong commented on PR #1524:
URL: https://github.com/apache/airflow-site/pull/1524#issuecomment-4429378053
@choo121600
I addressed this in the following commits:
https://github.com/apache/airflow-site/pull/1524/commits/ba94eb73de2293876396c9c05c7ae1891b1a1adc,
https://github.com/apache/airflow-site/pull/1524/commits/56ca38f231261e523716b55d3489b1897af35ac2
- Consideration 1:
I checked most page types and found that each page type uses its own HTML
layout. Moving everything to a single shared layout would require a larger
template refactor.
For this PR, I focused on cleaning up navbar height management and sharing
page vertical spacing styles.
- Consideration 2:
I added `_shared.scss` for values that are reused across pages, such as
`navbar-height` and `page-spacing-y`.
Technically, the navbar height values could live in `_navbar.scss`, since
they are navbar-related. However, they are also used by other page-level
styles for layout calculations, so keeping them in `_shared.scss` feels clearer
to me.
There are many implicit CSS dependencies due to selector-based styling, and
we do not have tests or design guidelines to catch regressions. So changing CSS
or HTML can introduce side effects that are hard to catch.
As a first step, these changes look good to me and should help reduce
regressions in follow-up changes.
Would appreciate your thoughts on this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
