Subham-KRLX commented on code in PR #67222:
URL: https://github.com/apache/airflow/pull/67222#discussion_r3279193691


##########
providers/amazon/src/airflow/providers/amazon/aws/utils/waiter_with_logging.py:
##########
@@ -30,6 +30,28 @@
 if TYPE_CHECKING:
     from botocore.waiter import Waiter
 
+# Standard throttling and transient error codes to retry on
+# https://docs.aws.amazon.com/general/latest/gr/api-retries.html
+# and https://github.com/boto/botocore/blob/develop/botocore/retryhandler.py
+RETRIABLE_ERROR_CODES = {

Review Comment:
   These error codes are from AWS documentation and are pretty stable but you 
are right that we'd need to maintain the list manually for now I think the 
hardcoded approach is fine since these codes change infrequently we could 
definitely explore importing them from botocore in a future improvement. Let me 
know if you'd prefer I investigate that option for this PR or if the documented 
list works for now.
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to